Build and push nuget artifacts #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgiannuzzi
reviewed
Nov 20, 2023
|
The |
I will add this to the PR desc |
|
Environment and secret created + PR description updated |
dave-gantenbein
approved these changes
Nov 20, 2023
* Add push nuget workflow job. Refactor magefile to only pack nuget not pack&push Signed-off-by: Ivan Pavlovic <[email protected]>
Signed-off-by: Ivan Pavlovic <[email protected]>
jgiannuzzi
approved these changes
Nov 20, 2023
severinson
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is an improvement PR
What this PR does / why we need it:
This PR add workflow jobs that pack and push nuget artifacts, Armada clients
Special notes for your reviewer:
Magefile target that was doing both pack and push (named
PushNuget), has been refactored to only pack nuget, thus implementing single responsibility principle.Prerequisites:
nuget-releasewith theNUGET_API_KEYsecret